Stop exporting check_event_sanity
authorMatthias Clasen <mclasen@redhat.com>
Thu, 20 Feb 2020 22:13:21 +0000 (17:13 -0500)
committerMatthias Clasen <mclasen@redhat.com>
Fri, 21 Feb 2020 05:51:03 +0000 (00:51 -0500)
gdk/gdkevents.c
gdk/gdkeventsprivate.h
gdk/wayland/gdkeventsource.c

index ac46600a2805b0f092d5e1e7a5d4168413247868..e66bbd4fd615e01e49135174280608181197bd31 100644 (file)
@@ -68,29 +68,23 @@ G_DEFINE_BOXED_TYPE (GdkEvent, gdk_event,
                      gdk_event_ref,
                      gdk_event_unref)
 
-gboolean
+static gboolean
 check_event_sanity (GdkEvent *event)
 {
-  GdkDisplay *display;
-  GdkSurface *surface;
-  GdkDevice *device;
-
-  display = gdk_event_get_display (event);
-  surface = gdk_event_get_surface (event);
-  device = gdk_event_get_device (event);
-
-  if (surface && display != gdk_surface_get_display (surface))
+  if (event->any.device != NULL &&
+      gdk_surface_get_display (event->any.surface) != gdk_device_get_display (event->any.device))
     {
       char *type = g_enum_to_string (GDK_TYPE_EVENT_TYPE, event->any.type);
-      g_warning ("Event of type %s with mismatched surface display", type);
+      g_warning ("Event of type %s with mismatched device display", type);
       g_free (type);
       return FALSE;
     }
 
-  if (device && display != gdk_device_get_display (device))
+  if (event->any.source_device != NULL &&
+      gdk_surface_get_display (event->any.surface) != gdk_device_get_display (event->any.source_device))
     {
       char *type = g_enum_to_string (GDK_TYPE_EVENT_TYPE, event->any.type);
-      g_warning ("Event of type %s with mismatched device display", type);
+      g_warning ("Event of type %s with mismatched source device display", type);
       g_free (type);
       return FALSE;
     }
index 7f7d7ffe73136c685f01e13271122d23a28181e4..6505d548d180d3c870b059a34fce1b361f70a5a6 100644 (file)
@@ -534,8 +534,6 @@ union _GdkEvent
   GdkEventPadGroupMode      pad_group_mode;
 };
 
-gboolean       check_event_sanity (GdkEvent *event);
-
 GdkEvent * gdk_event_button_new         (GdkEventType     type,
                                          GdkSurface      *surface,
                                          GdkDevice       *device,
index 31bbb165f1f164357c51bd2acaf9a811bb7744bb..8db92954e8d60c24e67958583e32768c23289f87 100644 (file)
@@ -170,9 +170,6 @@ _gdk_wayland_display_deliver_event (GdkDisplay *display,
 {
   GList *node;
 
-  if (!check_event_sanity (event))
-    g_warning ("Snap! delivering insane events\n");
-
   node = _gdk_event_queue_append (display, event);
   _gdk_windowing_got_event (display, node, event,
                             _gdk_display_get_next_serial (display));